Clarify Dashboard Send/Receive flows #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKitty
added
Enhancement
|
Easy change, looks better tbh. Tested on PC, S23 Ultra, S10+ and Tab S8 Ultra. All Chrome and Firefox! 🎄🐦 |
BreadJS
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR simply clarifies the "Send" and "Receive" flows by swapping out the icon buttons for i18n-supported text buttons.
Additionally, the "Transfer" title was removed from the Send dialog, since it used unnecessary space and was written ambiguously, this also drops a key from the i18n system, so slightly less work for the translation teams!
New Buttons
New Send Menu
This PR closes #165
Testing
This PR is nice and simple:
If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!